I'd like hear any thoughts on the pros & cons of leaving
pre-existing storm windows in place when installing high efficiency
replacement units from the inside. Are there moisture entrapment concerns and is insulating value gained?
There are moisture entrapment concerns, that are easy to fix with having a ample flow of air, to create with some little holes at the bottom and on top through your existing storm windows ('frame).
The moisture entrapment will show as a film of damp, or on the existing window
or on the new window.
This depends only on where the dew point is situated, this depending on the temperatures outside and inside the room.
The insulating value will be better when you add your high efficiency (isolated) window.
Make sure you block those vent holes with a little fine fly screen. If you do not, large numbers of wasps and other insect will see them as ideal dens and one then enter, will not find the exit. Over time a lot of dead insects will build up in the bottom of your window.
And make sure they are at the bottom only. You do not want a convective flow, you want about a total of 1/4 square inches of vent
Naturally You would get a little more insulating power. Thats the plus side. On the negative side You would still have the look of old windows plus if You like to open Your windows on nice spring days You would need to open 2 windows. Then there is the cleaning problem, the new windows are probably the tip out type where You can clean from inside but You still need to clean the old storms. Now you need to balance the negative with the positive, is it worth the extra work and the asthetics?
About 15 years ago, we replaced old windows with triple pane windows (Pella brand). Biggest benefit was not so much the energy savings (which were good) but the interior sound reduction was amazing. The triple pane opens as a unit, so I have no issues with putting and taking down storms. It did cost alot, so we staged the work over a 3 year time frame by doing 3 or 4 windows a year. Still enjoy the investment.
__________________
Eventually, one needs to realize that it is far less important to be the smartest person in the room than it is to sit next to that person and make friends.