Help with Program Code?

Wow

what is the wrong???

Its your program, at least that is what you claim. If any one here could find what is wrong with it, it would be theirs now, wouldn't it?

You hang in there Mate, Rome was not built in a day, Ky.

Sorry, I can't/won't help. We all have these problems, it's the act of solving them that makes us better and faster programmers for next time.

Break it down into smaller steps and see if each bit does what you think it does.

By the way,

if(s1==0 && s2==0 && s3==0)
return 0; etc

can be simplified a tad, try reading the inputs as a word and masking unused bits

I would say for one thing that You do not check for signal change but only for signal state, as You have to save previous state of input lines and compare new state with this to see if there is change.

Then You have to add condition test of B0==0 even if You detect change on input lines, which is not there even if comment say it is........

Last but not least, I would do it using bits switching in control byte and test whole byte for change in comparison with saved state of control byte.

If there is change and B0==0, then all You need to do is to have test to check which bit is on and send corresponding pulse on output line.

That way You get all combinations covered very simply without need for testing which it actually is, else for all Your numbered combinations You have to have same combination of outputs.

Now only question is whether You have to have signals in parallel when outputting them or You can do each one after another (I know about leech circuits that keep holding signal on line after getting them switched on, but I do not know what You are using as I am not Engineer of Electronic, just an old pro in programming that happened to have programmed controller for Magnetic Tape device that my friend has made for me).

I do not know if You can use threads in case signals have to go in parallel, but I guess it is not applicable here.

Main rule in programming is to make it as simple as possible, and in my time also with as few instructions as possible.

Sorry that I have no time to go over this program in details, and I was not programming in C for at least 20 years, so I am little rusty in that department :-))

Sorry, I wrote >>test of B0==0 << when it should have been >>test of B3==0<<.....

Another advice: we were testing program on the paper in old times, where You write table with names and state they have, and then walk trough program one instruction at time and see if it do what it is supposed to do. Make sure You set and test all combinations of input and check whether You get appropriate combination on output....

Then also You can add simple routine that would generate all combination of inputs and let program run on those inputs, with printout of inputs and outputs which You can check for correctnes.......

So when You are sure it is all working correctly, you remove input generating routine and output printing, and You have program You need to do whatever it is.........

I don't have any knowledge experience or real understanding: but,

What delimits what happens in the for loop?

Should this:

for(i=0; i<which_MSG(); i++)
cursor();
menu();
menu();
cursor();
menu();
menu();
cursor();
menu();
menu();
end();
goto start;
}

Look like something like this

for(i=0; i<which_MSG(); i++)
{
cursor();
menu();
menu();
cursor();
menu();
menu();
cursor();
menu();
menu();
end();
}
goto start;
}

Yes, that goto in a loop is mistake definitely!

But this is also syntax error to forget to write parentheses

(IF it is "C" language) so this program is not compiled also.........

Test on B3==0 should be uncommented.

Subroutine labeling/names are badly chosen

(end(), cursor(), menu()) as names do not reflect

function performed and therefore create confusion.

Then instead

goto messaging

whole program part under messaging:

should be put there instead.

This is because messaging is not referenced anywhere else,

so it is not necessary.

It is not explained why pulses on some lines are repeated

different number of times, and program has no way to

finish working as it always cycle back to "start:"

>> for(i=0; i<which_MSG(); i++)

this is bad practice to set condition for end of loop on function

result that could change, as compiler should execute function

which_MSG()

each loop pass before comparing it to i, so if returned value

is changed, for can loop forever or one or more states would

be skipped as only highest value would be used to finish the loop.

But, this depend on frequency of state changes.

So better practice would be to assign value of message to variable

j==which_MSG() and then use this variable to control the loop.........

for(i=0; i<j; i++)

Still it is not clear why same sequence of pulses should be repeated

according to message value.........

Obviously this is a homework only without practical value, and we should have not interfered with our Guest learning process :-((

One obvious problem is the Goto jump in the for loop. Try to write the program without goto to get away from the spaghetti logic.