Why This Error Displayed: Insufficient Memory..

I would suggest posting this question on comp.lang.c++.

Thanks.

How to find the place?

http://groups.google.com/group/comp.lang.c++/topics?hl=en

I'm sorry to say that at this range it is quite impossible to sort out your problem. We do not even know if the problem is software or hardware (if you are working on an old machine it might be a RAM problem). In software there are any number of causes, related to not clearing up memory used by variables, and to using pointers which are not properly initialised, and so point to undefined memory areas. It can only get worse if you are modifying someone else's program, particularly if it is not properly commented. Any variable which is created by new() should also be disposed of by delete() within the appropriate scope. I have written a large project with a database in C++ Builder 5, so it is a perfectly adequate tool for the job, but the only way you will get to the bottom of this is to show your whole code (not just the tiny fragment you have shown us) to a programmer. You may also find you need to adjust some settings in the compiler to allow for a bigger heap and stack.

Hi, phph001,

You are great, thank you.

The code is very large which started from 2002 and transfered for several guys.

I know little about C++ Builder 5.0, so could you help to show me how to change the heap and stack size in it? In "Project Opitions/Linnker/PE file option" or in "Project Opitions/Tasm/Sections"?

Thank you again.

Sorry, I have given up on C++ and it is no longer on my machine, but you should find the heap and stack settings of one of the Project Options sub-menus. It may well be Linker, but not Tasm (which is for assembly language).

Thank you. phph001.

Hi, msamad,

Thank you very much.

Maybe I am not stated clearly.

1) I found in main form *.cpp file has declaration:TDataConfig* Config;

2) I meant 'Construction function' equals Constructor of class TDataConfig, not TDatabase. Previously I said was not correct. Sorry for this.

Besides above,

(1) in TDataConfig head file:

class TDataConfig : public TDataModule
{
__published: // IDE-managed Components
TDatabase *ConfigDB;
TQuery *QueryCONFIG;
TUpdateSQL *UpdateSQLCONFIG;
private:

...

public:

int LineNumber;

int LinePosition;

int __fastcall Read(String Item, int Default);

......
public: // User declarations
__fastcall TDataConfig(TComponent* Owner);
__fastcall TDataConfig();

bool __fastcall Initialize();

......

(2) in TDataConfig cpp file, has a Read function:

int __fastcall TDataConfig::Read(String Item, int Default)
{
String S = "";
int Result;
S = "";
if( QueryCONFIG->RecordCount != 0 )
if(QueryCONFIG->FindField(Item) != NULL)
S = QueryCONFIG->FindField(Item)->Value;
Result = S.ToIntDef(Default);
return Result;

}

(3) in TDataConfig cpp file, Initialize function(displayed again):

bool __fastcall TDataConfig::Initialize()
{
bool Result;
String S;
ErrNum = 0;
ErrStr = "No Error";
if(!ConfigDB->Connected){
try{
ConfigDB->Connected = true;
}catch(...){
ErrNum = 9;
ErrStr = "Failed to connect to SEAL_CONFIG database! The file might be missing or corrupted!";
return false;
}
}

QueryCONFIG->Active = false;
S = "select * from SEAL_CONFIG_NEW where SN = '" + SN + "'";
QueryCONFIG->SQL->Clear();
QueryCONFIG->SQL->Add(S);
QueryCONFIG->Active = true;

LineNumber = Read("LineNumber",0);
LinePosition = Read("LinePosition",0);

......

By the way, this program runs on a PC with Pentium III, 256M RAM, also has a virusscan software--McAfee.

This error occurs occasionally.

Any suggestion?

Thank you again.

I would recommend you first to see the memory leak. This type of error generally appears in the case where memory is not properly released after it is dynamically allocated. If the program runs for a while and after certain time, the error appears and it works ok after it is restarted – the most probably cause is the memory leak.

- MS

Hi, Msamad,

Thank you.

Do you have any general solution on this memory leak? I know little about this.

Hi, Thank you both.

I will check the code again to find 'new-delete' words paired or not.

Hi, msamad,

I have checked the source code, and find some suspicious place. Now I list 2 place of them. Can you help me how to modify them?

---------------------------------------------------------------------------------

1) In MainForm.h, I find the definition:

TIOButton *DIn[MAX_IO];

TIOButton *DOut[MAX_IO];

---------------------------------------

and in MainForm.cpp I find:

void __fastcall TForm1::CreateIOButtons()
{
int i = 0;
int Top = 10;
int Left = 12;
for( ; i<22; ++i )
{
//Inputs
DIn[i] = new TIOButton(this);
DIn[i]->Parent = TabInputs1;
DIn[i]->Left = Left;
DIn[i]->Top = Top;
//Outputs
DOut[i] = new TIOButton(this);
DOut[i]->Parent = TabOutputs1;
DOut[i]->Left = Left;
DOut[i]->Top = Top;
Top += 40;
if( i == 10 )
{
Top = 10;
Left = 404;
}
}
Top = 10;
Left = 12;
for( ; i<44; ++i )
{
//Inputs
DIn[i] = new TIOButton(this);
DIn[i]->Parent = TabInputs2;
DIn[i]->Left = Left;
DIn[i]->Top = Top;
//Outputs
DOut[i] = new TIOButton(this);
DOut[i]->Parent = TabOutputs2;
DOut[i]->Left = Left;
DOut[i]->Top = Top;
Top += 40;
if( i == 32 )
{
Top = 10;
Left = 404;
}
}
Top = 10;
Left = 12;
for( ; i<66; ++i )
{
//Inputs
DIn[i] = new TIOButton(this);
DIn[i]->Parent = TabInputs3;
DIn[i]->Left = Left;
DIn[i]->Top = Top;
//Outputs
DOut[i] = new TIOButton(this);
DOut[i]->Parent = TabOutputs3;
DOut[i]->Left = Left;
DOut[i]->Top = Top;
Top += 40;
if( i == 54 )
{
Top = 10;
Left = 404;
}
}

}

----------------------------------------

You can see from above statement, there are 6 "new" and I can't find any delete in the whole program.

How can I modify this part?

-------------------------------------------------------------------------------

2) I also find some "new" in other class:

In FOFLightTower.cpp has "new" like:

// ValidCtrCheck is used to assure that the components created do not have
// any pure virtual functions.
//
static inline void ValidCtrCheck(TFOFLightTower *)
{
new TFOFLightTower(NULL);

}

...

__fastcall TFOFLightTower::~TFOFLightTower()
{

}

How do you think of this type "new"?

Thank you very much.

A correction:

In the for loop, replace 22 with 66.

Please come up with the result.

- MS

Thank you, Msamad,

Because of other issue I have to postpone this project for 2 weeks.

Anyway, I will give you the last result after I get it.

Thank you again.

Hi, Msamad,

Thank you.

The program is ok now.

I am glad to know that you got helped.

- MS